From 2fad8e1808fb84fbda05c93ee0a1a851df88a709 Mon Sep 17 00:00:00 2001
From: Chris Christiansen <chris.christiansen@vauco.no>
Date: Sat, 5 Sep 2026 21:14:45 +0000
Subject: [PATCH] fix(mcp): default ticket_id when caller passes null; set
 OSVAUCO_AGENT_URL

---
 deploy_mcp.sh      | 2 +-
 opax-mcp.yaml      | 2 ++
 opax-mcp/server.py | 2 +-
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/deploy_mcp.sh b/deploy_mcp.sh
index e5b3977..0e8ea21 100755
--- a/deploy_mcp.sh
+++ b/deploy_mcp.sh
@@ -18,7 +18,7 @@ echo "=== 3. Push image ==="
 docker push "${FULL_IMAGE}"
 
 echo "=== 4. Deploy with pre-built image ==="
-gcloud run deploy "${SERVICE}"   --image="${FULL_IMAGE}"   --region="${REGION}"   --service-account="jason-vauger@${PROJECT}.iam.gserviceaccount.com"   --set-secrets="MCPSECRET=mcp-server-key:latest"   --allow-unauthenticated   --port=8080   --memory=512Mi   --cpu=1   --min-instances=0   --max-instances=2   --quiet
+gcloud run deploy "${SERVICE}"   --image="${FULL_IMAGE}"   --region="${REGION}"   --service-account="jason-vauger@${PROJECT}.iam.gserviceaccount.com"   --set-env-vars="OSVAUCO_AGENT_URL=https://osvauco-agent-zjbqp3prqq-uc.a.run.app"   --set-secrets="MCPSECRET=mcp-server-key:latest"   --allow-unauthenticated   --port=8080   --memory=512Mi   --cpu=1   --min-instances=0   --max-instances=2   --quiet
 
 echo "=== 5. Verify ==="
 SVC_URL=$(gcloud run services describe "${SERVICE}" --region="${REGION}" --format='value(status.url)')
diff --git a/opax-mcp.yaml b/opax-mcp.yaml
index 4217550..f8eb669 100644
--- a/opax-mcp.yaml
+++ b/opax-mcp.yaml
@@ -76,6 +76,8 @@ spec:
             secretKeyRef:
               key: latest
               name: TWILIO_FROM_NUMBER
+        - name: OSVAUCO_AGENT_URL
+          value: https://osvauco-agent-zjbqp3prqq-uc.a.run.app
         - name: MCPSECRET
           valueFrom:
             secretKeyRef:
diff --git a/opax-mcp/server.py b/opax-mcp/server.py
index 949b51f..e277fef 100644
--- a/opax-mcp/server.py
+++ b/opax-mcp/server.py
@@ -392,7 +392,7 @@ async def create_a2h2a_ticket(p: dict) -> dict:
     import uuid, hashlib, hmac, os
     
     db = firestore.Client(project="propane-will-491900-m5")
-    ticket_id = p.get("ticket_id", f"a2h2a-{uuid.uuid4().hex[:8]}")
+    ticket_id = p.get("ticket_id") or f"a2h2a-{uuid.uuid4().hex[:8]}"
     
     # Generate review token
     secret = os.getenv("MCPSECRET", "")